Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crud): merge crud options from methods and classes #430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Diluka
Copy link
Contributor

@Diluka Diluka commented Feb 26, 2020

Since CrudRequestInterceptor can be used detached, there is a problem about the incoming query and the static built-in query. Every methods which use CrudRequestInterceptor out of crud can have a options by their own. The search option solved the problem about query merge. But comes a new one that the filter set after req created does not take effect. So put this options in method's metadata and CrudRequestInterceptor gets from it before req created to make it work.

use SetMetadata(CRUD_OPTIONS_METADATA, { query, params }) in my custom decorators and CrudRequestInterceptor will get this from method.

@rewiko
Copy link
Collaborator

rewiko commented Nov 28, 2021

I am trying to help and have forked this repo (can't reach the owner of this repo and do not have the credential for the npm repo).

See #710 (comment)

We can hopefully merge it via rewiko#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants