Concurrency issue #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm simply following the same approach we went through in sysbox-mgr repo. Signed-off-by: Rodny Molina <rmolina@nestybox.com>
Bug is fairly obvious here. Problem is triggered whenever no matching user-ns is found during the container registration phase, which could be a consequence of a timing / transient condition such as the container initialization process being abruptly terminated. The following logs display the issue right before the deadlock was observed: ``` Apr 23 13:25:26 vm1 sysbox-fs[18766]: time="2021-04-23 13:25:26" level=warning msg="Error during syscall \"umount2\" processing on fd 23 pid 10907 (mountInfoParser error for pid = 10907: Error waiting for sysbox-fs first child process)" Apr 23 13:25:26 vm1 sysbox-fs[18766]: time="2021-04-23 13:25:26" level=error msg="No namespace file found /proc/17775/ns/user" Apr 23 13:25:26 vm1 sysbox-fs[18766]: time="2021-04-23 13:25:26" level=error msg="Container registration error: container 66279db8b73fa4c13a5198c62d4af8d91869783ef5c88c52c9952ec71eef5cab with invalid user-ns" Apr 23 13:25:26 vm1 sysbox-fs[18766]: time="2021-04-23 13:25:26" level=warning msg="Sysbox-fs first child process error status: pid = 18423" ``` Signed-off-by: Rodny Molina <rmolina@nestybox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to individual commits for details.