-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mask dmesg_restric
as part of procSysKernel handler
#77
Conversation
c6d3375
to
74f0254
Compare
@rodnymolina this indeed fix the issue. Can be tested with: $ docker run --rm --runtime sysbox-runc ubuntu sysctl kernel.dmesg_restrict=0
kernel.dmesg_restrict = 0 Without these changes, it fails with: $ docker run --rm --runtime sysbox-runc ubuntu sysctl kernel.dmesg_restrict=0
sysctl: permission denied on key "kernel.dmesg_restrict", ignoring |
@felipecrs, your changes look good but there are a couple of issues that need to be addressed before you merge this PR:
|
86d3754
to
f8aa00f
Compare
Hi @rodnymolina, sorry about that. I was applying the patch on top of v0.5.2, and that's why it was outdated. I totally forgot to update it while creating the PR. Thanks for finishing it as well. I also squashed your commit into mine to keep the history clean. |
Co-authored-by: Rodny Molina <rodny.molina@docker.com> Signed-off-by: Felipe Santos <felipecassiors@gmail.com> Signed-off-by: Rodny Molina <rodny.molina@docker.com>
f8aa00f
to
7b5db6d
Compare
dmesg_restric
dmesg_restric
as part of procSysKernel handler
Thanks @felipecrs -- I just verified that things are looking good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
/proc/sys/kernel/dmesg_restrict
inside system containers sysbox#599