Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add every unique header to kernel headers mount #744

Closed
wants to merge 1 commit into from

Conversation

michiboo
Copy link

@michiboo michiboo commented Nov 9, 2023

Signed-off-by: micky <chanmickyyun@gmail.com>
@ctalledo
Copy link
Member

Hi @michiboo, apologies for the delay in reviewing and thanks very much for your contribution.

I looked at the propose change, and I think it's a band-aid in the test container that in a way hides a deeper bug in sysbox-mgr (i.e., the inability of sysbox-mgr to deal properly with mounting kernel headers into sysbox containers in some scenarios).

I have a proper fix for the sysbox-mgr bug, for which I will open a PR this week. Therefore, I don't think the fix you propose in this PR is needed, and I prefer to not accept it as otherwise the test container (inside of which Sysbox is tested) will not look quite like a real host, but rather have unique mounts for each kernel header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants