Update to Swift 4.2 #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 19, 2018 15:20
- AFNetworking was updated from 3.1.0 -> 3.2.1 - Alamofire was updated from 4.4.0 -> 4.7.3 Using Cocoapods 1.6.0.beta.2
flipacholas
commented
Nov 19, 2018
| @@ -36,4 +36,4 @@ enum SessionMockError: Error { | |||
| /** | |||
| A default delay to use when mocking requests | |||
| */ | |||
| var DefaultDelay: Double = 0.25 | |||
| public var DefaultDelay: Double = 0.25 | |||
There was a problem hiding this comment.
I'm not sure if you intended to have this global variable as public, but it seems that Swift doesn't allow to use private vars on public functions as default values on parameters anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes and optimisations that bring the project up to date with the new Swift syntax.