Create native feature runner that can explicitly run a scenario from a test #50
Conversation
Pod/Native/NativeRunner.swift
Outdated
|
|
||
| public class func runScenario(featureFile: String, scenario: String?, testCase: XCTestCase) { | ||
| testCase.state.loadAllStepsIfNeeded() | ||
| let path = (Bundle(for: type(of: testCase)).resourceURL?.appendingPathComponent(featureFile))! |
There was a problem hiding this comment.
Hey, we usually discourage the use of force unwrapping. Do you think we could split this out into a couple of guard lets and fail the test here?
Pod/Native/NativeRunner.swift
Outdated
| let features = loadFeatures(path: path) | ||
|
|
||
| for feature in features { | ||
| let scenarios = feature.scenarios.filter({ scenario == nil || $0.scenarioDescription.hasPrefix(scenario!)}); |
There was a problem hiding this comment.
What do you think of making this not inline and removing the semicolon?
Pod/Native/NativeRunner.swift
Outdated
|
|
||
| for feature in features { | ||
| let scenarios = feature.scenarios.filter({ scenario == nil || $0.scenarioDescription.hasPrefix(scenario!)}); | ||
| if scenarios.count < 1{ |
There was a problem hiding this comment.
Nitpicky, but you're missing a space between 1 and {
| } | ||
|
|
||
|
|
||
| private class func loadFeatures(path : URL) -> [NativeFeature] { |
There was a problem hiding this comment.
nitpicky, but can we remove the space between path and :
| } | ||
|
|
||
| for scenario in scenarios { | ||
| let allScenarioStepsDefined = scenario.stepDescriptions.map(testCase.state.matchingGherkinStepExpressionFound).reduce(true) { $0 && $1 } |
|
@jacdevos could you plz update the PR so this can be merged? it's been open for a while |
|
@smaljaar If you're interested in this getting into master I don't mind merging it and fixing it myself? |
|
@smaljaar my bad, I'll make some time for it this week, it has been quite useful on our projects. |
|
@kerrmarin @smaljaar I've pushed the style changes you (rightly) suggested. I also have a few tests in ExampleNativeRunnerTest. I think we are ready to go. I have a few additions to this that came up in our project, but will submit those as a new PR. |
|
Thanks @jacdevos I'll investigate the test failures later today |
|
Looks like it was fixed by running the tests again :) |
| XCTFail("No scenario found with name: \(scenario)") | ||
| } | ||
|
|
||
| for scenario in scenarios { |
There was a problem hiding this comment.
This for loop is duplicate code copied from the NativeTestCase method featureScenarioTest(). I extracted the code from featureScenarioTest() into this auxiliary method in NativeTestCase so we avoid having the same code in two places:
class func perform(scenario: NativeScenario, from feature: NativeFeature, in testCase: XCTestCase) {
let allScenarioStepsDefined = scenario.stepDescriptions.map(testCase.state.matchingGherkinStepExpressionFound).reduce(true) { $0 && $1 }
var allFeatureBackgroundStepsDefined = true
if let defined = feature.background?.stepDescriptions.map(testCase.state.matchingGherkinStepExpressionFound).reduce(true, { $0 && $1 }) {
allFeatureBackgroundStepsDefined = defined
}
guard allScenarioStepsDefined && allFeatureBackgroundStepsDefined else {
XCTFail("Some step definitions not found for the scenario: \(scenario.scenarioDescription)")
return
}
if let background = feature.background {
background.stepDescriptions.forEach(testCase.performStep)
}
scenario.stepDescriptions.forEach(testCase.performStep)
}
You can now replace the body of this for loop with the line:
NativeRunner.runScenario(featureFile: featureFile, scenario: nil, testCase: testCase)
In NativeTestCase you can call this method like:
NativeTestCase.perform(scenario: scenario, from: feature, in: self)
If you like the suggestion, please use it 🙂
There was a problem hiding this comment.
Good suggestion @smaljaar - maybe create another PR for this, I see change has been merged.
|
@jacdevos I studied the NativeRunner class and I really like how you solved the problem of disappearing test cases in the Xcode Test Navigator 👍 |
|
@smaljaar glad you like it - it's been working quite well for us. There are a few enhancements that would help, which we can work on if we see the value: |
I created a direct, explicit native test runner for scenarios, based on my observation in Issue
#49
It allows you to create normal XCTests, and run native feature files explicitly, as in:
func testNativeExampleWithScenarioRunner() {
NativeRunner.runScenario(featureFile: "NativeFeatures/native_example.feature", scenario: "This is a basic happy path example", testCase: self)
}
This is just V0.001 so please give suggestions if the idea has wings.