Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate FLAG if it is being compiled in Windows #239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

studenttwok
Copy link

I revisit the issue #144 which I posted few years ago, modify the code (again) to make them work in V2.40010.

Compiled successfully on Windows 10 22H2 (64 bit) using Strawberry Perl v5.32.1 (64 Bit).
Pass all build tests.

@manchicken
Copy link
Contributor

@studenttwok Could you help me get this tested? GitHub Actions supports Windows VMs, would it be possible for you to make a Windows-specific Action? I don't have a Windows machine to test on.

@studenttwok
Copy link
Author

@manchicken Not sure if that is what you want. It is not easy to create a Win + Perl +MSBuild environment on GitHub workflow. I tested in my local machine with act and it works(Not sure if it works on GitHub too, however).

A CI file is added to support windows workflow.

The workflow is not perfect and I am not sure I can improve it in the near future.
Please make changes if you find any problem.

@studenttwok
Copy link
Author

One more note on my pull request.
For windows user, symlink support should be explicitly enabled before pulling the repo.
This article is a good starting point: https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows/52097145#52097145
In short,
git clone -c core.symlinks=true -b windows_makefile_fix https://github.com/studenttwok/net-amqp-rabbitmq.git
Will be the right command after symlink support is enabled in Windows 10, Besides, administrator privilege is required when creating the symlinks.

@manchicken
Copy link
Contributor

You can use Docker, no?

@studenttwok
Copy link
Author

You can use Docker, no?

Do you mean that I should create a docker image that with all the necessary libraries and tools (Perl+vc build tool+win) preinstalled? Then include it in the GitHub workflow. What I should specify in the workflow will be loading the source using checkout and execute the test?

Sorry because I have not much experience in dealing with GitHub workflow, just want to make sure if that is the correct way and normal practice.

@manchicken
Copy link
Contributor

No worries, friend. Take a peek at the GitHub Discussion I just started, where I discuss a number of the challenges facing the library at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants