Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Some) Wheels are not working as expected. #3

Open
Lisias opened this issue Jun 16, 2022 · 6 comments
Open

(Some) Wheels are not working as expected. #3

Lisias opened this issue Jun 16, 2022 · 6 comments
Assignees

Comments

@Lisias
Copy link

Lisias commented Jun 16, 2022

Hyratel reported on Forum

looks like the biplane and blackhawk wheels are still Broke As Hell for tail draggers. Haven't successfully tried them with a tricycle yet

He's right: I detected that the biplane wheels are incorrectly oriented, and also kicking the craft up at launch. If you use a LSE, then the craft drops into the ground and don't kick.

Task: check all the wheels, and fix what's broken.

@Lisias Lisias self-assigned this Jun 16, 2022
@Lisias
Copy link
Author

Lisias commented Jun 17, 2022

Manul also reported:

The smallest retractable gear had been doing this since KSP v 1.4 :D

Lisias pushed a commit that referenced this issue Aug 31, 2022
Move content from dev to master
@Lisias
Copy link
Author

Lisias commented Aug 14, 2023

Pull request #11 should fix this.

Checking it now.

@Lisias
Copy link
Author

Lisias commented Aug 14, 2023

We have still some issues here, after merging the #11 :

  • The biplanegear are still bumpy at launch.
  • The blackhawkgear wheels animation is inverted on one side (ie., the wheel turns backwards compared to the original one)
  • The miggear is floating some inches above the ground.
    • The collider appears to be a few inches to big or too low
  • The airbusgear wheels animation is inverted on one side (ie., the wheel turns backwards compared to the original one)
  • The herculeshear is bumpy at launch.
    • It's also a bit "buried" on the ground, the collider appears to be a few inches too small or too high.
    • It's also being rotate 90o at launch!!!
      • screenshot104
  • The x1gear have the lights always on (the light bulb is not being lightened)
  • The x1sidegear animation is inverted on one side (ie., the wheel turns backwards compared to the original one)
    • It's also a bit "buried" on the ground, the collider appears to be a few inches too small or too high.

Crafts used on the test: SPH.143.zip

@Lisias
Copy link
Author

Lisias commented Aug 14, 2023

To be on the safe side, I reproduced the tests on KSP 1.12.5. I recreated the crafts from scratch, to be absolutely sure no side effects from the upgrade pipeline (if any) would affect the crafts.

All the problems were reproduced the same. The biplanegear problem appears to be worse, and the blackhawkgear at least once was incepted withtout the colliders with the craft rolling over the runway as the gears weren't there.

I think I need to analyse these gears further before releasing them.

craft files: Uploading SPH.125.zip…

@Lisias
Copy link
Author

Lisias commented Aug 14, 2023

I found this pretty weird, so I decided to download the complete distribution from SuicidalInsanity's fork, source of the #11 .

Exactly the same problems, so this is not something I screwed up while doing the merge. :/

@Lisias
Copy link
Author

Lisias commented Aug 15, 2023

So I reverted the changes and did all the tests again:

  • The biplanegear are still bumpy at launch, but it's also inverted - rendering it unusable.
  • Idem for the blackhawkgear.
  • The miggear sunks on the runway (no collider, it's the same on Firespitter gears). It's not recoverable (see next item)
  • The airbusgear starts the game under the runway, but if you retract and extend the gears, it works fine after.
  • The herculesgear is working flawlessly, however. I found no issues on the original one...
    • Other than one set of wheels spinning backwards...
  • The x1gears start a bit bumpy, but other than that works fine - and the lights are not screwed.
    • And yeah, one side of the wheels on symmetry are spinning backwards…

I'm considering remerging the thing, but without the herculesgear and the x1gear (the x1sidegears appears to be more stable on the SuicidalInsanity's version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant