Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some engines are exhausting the wrong way! Revise the engines. #2

Closed
Lisias opened this issue Jul 14, 2019 · 6 comments
Closed

Some engines are exhausting the wrong way! Revise the engines. #2

Lisias opened this issue Jul 14, 2019 · 6 comments
Assignees
Milestone

Comments

@Lisias
Copy link

Lisias commented Jul 14, 2019

The exhaust is being drawn in the opposite way.

All TDRCS has this issue.

@Lisias Lisias added this to the 0.9.0.0 milestone Jun 7, 2022
@Lisias Lisias self-assigned this Jun 11, 2022
@Lisias
Copy link
Author

Lisias commented Jun 11, 2022

Aw, crap. The damned thing is working fine on KSP 1.3.1…

So it's something that changed on some later KSP, 1.4.0 I'm guessing…

Test Craft (1.3.1): TDRCS test.craft.zip

screenshot70

@Lisias
Copy link
Author

Lisias commented Jun 11, 2022

Humm… Interesting. I think I misdiagnosed the problem.

On KSP 1.4.1, the TDRCS Thruster Block is working fine, besides thinking that the plumes are excessively big. Perhaps now the plumes are proportional to the trust?

The TDRCS Linear, on the other hand, are the ones with inverted plumes.

Test Craft: TDRCS test.craft.zip

  1. The Block is working fine - perhaps better than 1.3.1. But the plumes are too much, I think:
    screenshot39

  2. The Linear are the problematic ones:
    screenshot40

@Lisias
Copy link
Author

Lisias commented Jun 11, 2022

Hummm. Got it.

the II-TDRCS-Lin part had absolutely no EFFECT defined. On 1.3.1 it worked because KSP had reasonable defaults, but on KSP >= 1.4.0 the defaults changed (I'm guessing no defaults are being defined at all), and so the part started to misbehave.

Lisias added a commit that referenced this issue Jun 11, 2022
@Lisias
Copy link
Author

Lisias commented Jun 11, 2022

Success. Commit 4ea501a solves the problem for the II-TDRCS-Lin.

screenshot41

@Lisias Lisias changed the title RCS engines are exhausting the wrong way! Some engines are exhausting the wrong way! Revise the engines. Jun 11, 2022
@Lisias
Copy link
Author

Lisias commented Jun 11, 2022

I'm extending this issue to every engine on the II. Things are way outdated around here. :)

Lisias added a commit that referenced this issue Jun 11, 2022
@Lisias
Copy link
Author

Lisias commented Jun 11, 2022

II-TDRCS-Block fixed on b31604c

@Lisias Lisias modified the milestones: 0.8.10.0, 0.8.9.1 Oct 22, 2023
@Lisias Lisias closed this as completed Oct 22, 2023
@Lisias Lisias modified the milestones: 0.8.9.1, 0.8.10.0 Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant