Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Find and handle the use cases where the Auto Scale borks #166

Open
Lisias opened this issue Feb 12, 2021 · 6 comments
Open

TASK: Find and handle the use cases where the Auto Scale borks #166

Lisias opened this issue Feb 12, 2021 · 6 comments
Labels
task Not a problem, but something I must do and should not forget about
Milestone

Comments

@Lisias
Copy link

Lisias commented Feb 12, 2021

The recently (re)implemented feature Auto Scale is "code complete", but not "feature complete" yet - there're some borderline situations where the AutoScaling will bork, and these situations need to be mapped so I can tackle it down before shoving the stunt on the mainstream.

For example:
screenshot45
screenshot46
screenshot47

@Lisias Lisias added the task Not a problem, but something I must do and should not forget about label Feb 12, 2021
@AccidentalDisassembly
Copy link

AccidentalDisassembly commented Feb 13, 2021

Two things I noticed so far:

  1. CTRL-L conflicts with "no part offset limits" command from Editor Extensions Redux (I think?) - long term, might be better to have an app or toolbar button perhaps? Not sure.

  2. Autoscaling of certain stack decouplers/separators results in downscaling of the decoupler/separator to very small sizes. Tested with all stock decouplers; happens with every decoupler EXCEPT the 1.875m decoupler (from MH, I think) and the 5.0M decoupler. All others affected. Tested with random separators, same general trend.

Steps:
Place any part on a root part (didn't try with root part, but.. maybe then too). Turn autoscale on. Place any decoupler except 1.875m or 5m on the part placed before; it will get downscaled even if it's the same size as the part onto which it's placed. Ta-da!

image

(NOTE: Have EEX, KJR, and a few other utility mods installed on my mostly clean testing environment, so it could be interaction somehow... I guess.)

@Lisias
Copy link
Author

Lisias commented Feb 15, 2021

Thanks for the report, @AccidentalDisassembly . I will dive into it as soon as I manage to decide in which milestone this issue will be tackled down.

@Jammer-TD
Copy link

Just A Quick Review of the 2.5 Beta. see Pics and logs
1 11 2-test-2 5-Beta

ts25.0.31-1.11.2-01.zip

test was stopped once this was observed.
hope this helps
Jammer-TD

@Lisias
Copy link
Author

Lisias commented Apr 4, 2021

Jesus, that was interesting!

I suspect the problem is not exactly with the Chain Scaling, but with scaling parts with some specific characteristics. The Variant for sure, but not all variants misbehave like this...

@Jammer-TD
Copy link

Just 1 more thing this happens without "configurable containers" mod as well. I hadn't posted that info
Thanks
Jammer-TD

@Lisias Lisias added this to the 2.4.7.0 milestone Nov 21, 2021
@Lisias
Copy link
Author

Lisias commented Nov 21, 2021

Moving this one to the 2.4.7.x series, following the ROAD MAP.

@Lisias Lisias removed this from the 2.4.8.3 milestone Jan 26, 2023
@Lisias Lisias added this to the 2.4.7.6 milestone Mar 24, 2024
@Lisias Lisias modified the milestones: 2.4.7.6, 2.4.8.x Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Not a problem, but something I must do and should not forget about
Projects
None yet
Development

No branches or pull requests

3 participants