New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated TweakScale support on some parts #20
Comments
This can be triggered by the following situations:
In a way or another, TweakScale itself is not checking for the its presence before patching up, so I'm part of the problem myself (even if by luck I'm innocent this time). In a way or another, I need to revise the patches at the very least. |
I have to backtrack on the "my fault" setting. There's not a single way I could force a patch to be applied twice - on every single attempt, even by mangling ModuleManager's cache manually, a single instance of the TweakScale module data is the final result at runtime. No guesses for while. Still working on reproducing the problem, so I can test the fix!!! |
To making things clearer. This is what I was thinking I would find on the MM caches (but I didn't:
However, this is what I found instead:
I don't think it's a patch problem anymore. Aparently this can only be done programmatically, by code. |
HA! GOTCHA! :) This is an excerpt from the Module Manager's cache once I managed to force the problem.
However, the duplicated U.I. is not happening. :-( But the craft file is tainted as "expected":
Once I fixed the MM's cache (by hand), by loading the craft file the first instance of the TweakScale data is ignored, with the second instance being used instead - what "corrupts" the craft as these parts falls to default values at loading. |
Oh, joy. :D The code that detects a 0 sized list of ScaleFactors was preventing the code that detects the Duplicates to work. By "luck" :D on 1.6.1 a duplicated TweakScale module section has this info zeroed. Well… At least now it works. :) |
The Workaround works. Perfectly. Once the newest TweakScale is installed, every mangled craft file will be "mangled again" in a good way. All but the first instance will be persisted with the module name mangled (and a warning added) in order to prevent it from overwrite the live instance's data once the triggering misbehaviour (adding more than one instance of TweakScale on a part) is solved. |
Fixed on commit: b99d82f |
[(and yeah… it appears to be my fault)] - (no, it was not! :D )
(AccidentalDisassembly)
TASK: Revise the patches before the Big Refactoring from Krakens (tm), this appears to be two different patches trying to add different scalings (my guess: one for science, other for part size).
The text was updated successfully, but these errors were encountered: