New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine Effects are being scaled the wrong way! #27
Comments
More interesting stuff here The length of the plume is not being scaled at all on this specific case. |
This can be another symptom of the problem! |
Is there any plan/timeframe that this bug will be worked on? |
Made some more tests on 1.7.3, checking also the air breathing engines too. Behaviour consistent, but it's not exactly the same as the rocket ones. The tests were made It's not something TweakScale is doing wrong. It's simpler, it's something TweakScale is not doing. My hunch is that by understanding how exhaust works on KSP, a one or two liner on the Exponents will fix this. :) The behaviour for the air breathing engines are different from the ones for rocket engines, so it should be something on the engine module. |
For the record, I think the force vector of some engines may also being inverted (and the exhaust definitively are scaling inverted). From AccidentalDissasembly post:
HOWEVER... This is not affecting every engine, jet engines appears to look good - besides perhaps the length of the exhaust should also be extended (or shrink)? |
One fellow Kerbonaut contributed with a new test bed with a lot of engines. Thanks, Krazy1! For KSP 1.10: TS engine test.craft.zip |
The Engines exhaust is implemented on KSP using Particles (and it's not exactly the best implementation I ever saw on the matter), and the thing is generated procedurally by the Engine Module. So, I don't thing I will be able to easily tackle down this issue without some hacking on the engine modules - what potentially can create more more problems than the ones it would solve. However, there are people tackling this differently, using meshes. This is something that TweakScale does good, scaling meshes (it could not does it badly, it's just a scale number, the scaling is handled by the engine :P ). Check how things goes on https://forum.kerbalspaceprogram.com/index.php?/topic/196309-wip-waterfall-a-framework-for-continuous-mesh-driven-engine-effects-sept-3/ , this is promising. |
In time, SmokeScreen works fine with TweakScale, as it have embedded support for it - see this line on the SmokeScreen repository (on a side note: what the hell, line 666??? =D =D ) |
Moving this one to the 2.4.6.x series, following the ROAD MAP. |
Decided to tackle down this one sooner. |
This issue is blocked by #276 . So it's being moved to the same milestone. |
Just for the records: #276 is closed, so this issue is unblocked. |
Also, for the sake of curiosity (as it's more than evident that some scaling is happening nowadays): |
As the title says!
Well… Search and Destroy! (the bug)
Reporter: kocmohabt , here.
Evidences:
NERV
Vector
Reliant
The text was updated successfully, but these errors were encountered: