Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snmpd: support MemAvailable on Linux #167

Closed
wants to merge 1 commit into from

Conversation

ibigbug
Copy link
Contributor

@ibigbug ibigbug commented Aug 21, 2020

This is my first time walking into this code base, so I don't know what I'm doing.

But the idea is to add support of reporting MemAvailable on Linux

-> % free -h
              total        used        free      shared  buff/cache   **available**
Mem:          3.8Gi       437Mi       2.5Gi       5.0Mi       936Mi       3.2Gi
Swap:         4.0Gi          0B       4.0Gi

please guide if I'm doing this correctly and/or anything that is not covered

agent/mibgroup/hardware/memory/memory_linux.c Outdated Show resolved Hide resolved
agent/mibgroup/hardware/memory/memory_linux.c Outdated Show resolved Hide resolved
agent/mibgroup/hardware/memory/memory_linux.c Outdated Show resolved Hide resolved
agent/mibgroup/ucd-snmp/memory.h Outdated Show resolved Hide resolved
mibs/UCD-SNMP-MIB.txt Outdated Show resolved Hide resolved
@bvanassche
Copy link
Contributor

Please use git rebase -i origin/master to merge the changes that address review comments into the first patch and share the combined patch with e.g. the following command: git push +support-linux-avail-mem

@csmall
Copy link
Contributor

csmall commented Aug 24, 2020

I'm not sure what the RFC says but putting my procps (free, top) hat on for a second the available figure is the most useful. There is a commit floating around somewhere from Linus about why this is a good value to use for memory pressure (e.g. how much more memory can I allocate before causing memory issues such as swapping).

@ibigbug
Copy link
Contributor Author

ibigbug commented Aug 25, 2020

done ping @bvanassche

bvanassche pushed a commit that referenced this pull request Aug 29, 2020
See also #167 .

[bvanassche: modified the behavior of this patch]
@bvanassche
Copy link
Contributor

A modified version of this patch has been applied. Please take a look at commit 5b8bf5d .

@bvanassche bvanassche closed this Aug 29, 2020
@ibigbug ibigbug deleted the support-linux-avail-mem branch August 29, 2020 12:53
@ibigbug
Copy link
Contributor Author

ibigbug commented Aug 31, 2020

thanks @bvanassche

may I know when will this patch be released?

@bvanassche
Copy link
Contributor

The date of the next release has not yet been decided as far as I know.

@ibigbug
Copy link
Contributor Author

ibigbug commented Sep 28, 2020

@bvanassche any chance to have a release recently? so this can be leveraged by librenms/librenms#12110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants