Fix memory leak in ipAddressPrefixTable_data_access.c #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvanassche
pushed a commit
that referenced
this pull request
Sep 21, 2020
See also #183. [ bvanassche: adjusted commit message and reindented code ]
|
A slightly modified patch has been applied on the v5.9 and master branches. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory was leaked when, while populating ipAddressPrefixTable, "do we already have this prefix?" was true and no CONTAINER_INSERT happened afterwards. On my test system this always happened. In addition, the iterator was not released if memory allocation failed later, and the result of CONTAINER_INSERT was not checked.