chore: use GitHub actions #59
Conversation
|
|
||
| - name: Cache bundler | ||
| uses: actions/cache@v1 | ||
| id: bundler-cache | ||
| with: | ||
| path: vendor/bundle | ||
| key: ${{ runner.os }}-${{ matrix.ruby-version }}-gem-v3-${{ hashFiles('**/Gemfile') }}-${{ hashFiles('**/net-scp.gemspec') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-${{ matrix.ruby-version }}-gem-v3- | ||
| - name: Install dependencies | ||
| run: bundle install |
There was a problem hiding this comment.
It can be replaced with bundler-cache: true.
https://github.com/ruby/setup-ruby#caching-bundle-install-automatically
| - name: Cache bundler | |
| uses: actions/cache@v1 | |
| id: bundler-cache | |
| with: | |
| path: vendor/bundle | |
| key: ${{ runner.os }}-${{ matrix.ruby-version }}-gem-v3-${{ hashFiles('**/Gemfile') }}-${{ hashFiles('**/net-scp.gemspec') }} | |
| restore-keys: | | |
| ${{ runner.os }}-${{ matrix.ruby-version }}-gem-v3- | |
| - name: Install dependencies | |
| run: bundle install | |
| bundler-cache: true # runs 'bundle install' and caches installed gems automatically |
| matrix: | ||
| ruby-version: [2.3.8, 2.4.10, 2.5.9, 2.6.6, 2.7.6, 3.0.4, 3.1.2] | ||
| steps: | ||
| - uses: actions/checkout@v1 |
There was a problem hiding this comment.
| - uses: actions/checkout@v1 | |
| - uses: actions/checkout@v3 |
| runs-on: ubuntu-18.04 | ||
| strategy: | ||
| matrix: | ||
| ruby-version: [2.3.8, 2.4.10, 2.5.9, 2.6.6, 2.7.6, 3.0.4, 3.1.2] |
There was a problem hiding this comment.
I recommend not to specify minor versions unless there is a special reason.
| ruby-version: [2.3.8, 2.4.10, 2.5.9, 2.6.6, 2.7.6, 3.0.4, 3.1.2] | |
| ruby-version: ['2.3', '2.4', '2.5', '2.6', '2.7', '3.0', '3.1'] |
|
Any plan to push this forward and merge? |
|
@matejzero what are you interested in from this pr? net-scp 4 already support net-ssh 7, so that part is already merged. @cbeer can you please rebase and write a short summary of the proposed changes? |
|
Well, I think this one can be closed since it is almost identical to the changes I made in #64. |
It turns out this was already fixed with 4.0.0 release and I overlooked. Updated my Gemfile and it's working (puppet acceptance tests with AL9 and no SHA1 support). |
No description provided.