Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for v7.0.0+ releases #870

Closed
edmorley opened this issue Jun 26, 2022 · 5 comments · Fixed by #884
Closed

Update changelog for v7.0.0+ releases #870

edmorley opened this issue Jun 26, 2022 · 5 comments · Fixed by #884
Assignees

Comments

@edmorley
Copy link

v7.0.0 and v7.0.1 have been released:
https://github.com/net-ssh/net-ssh/tags

However they are not listed in the changelog:
https://github.com/net-ssh/net-ssh/blob/v7.0.1/CHANGES.txt

@rylanb
Copy link

rylanb commented Oct 17, 2022

This would be nice, a bit hard to know what changed in a major version bump.

@fwininger fwininger self-assigned this Oct 17, 2022
@tisba
Copy link
Contributor

tisba commented Oct 25, 2022

There are a ton of changes between 6.1.0 and 7.0.1, see net-ssh:74919ef...net-ssh:dc18e79. A lot of the 175 commits do look like cleanup and tooling. But it's hard to tell what else changed and I'm not sure it makes sense to generate a changelog from commit log.

7.0.0 to 7.0.1 is just removing a put/debugging statement (#866): net-ssh:a2b4cf1...net-ssh:dc18e79.

/cc @mfazekas

@swiknaba
Copy link

swiknaba commented Nov 6, 2022

A major version change infers (potential) breaking changes. At least documenting those would be great.

I went through all pull requests in the posted git diff from 6.1.0 to 7.0.1. None of the descriptions mention any breakages (most PR descriptions are shockingly blank, though).

@mfazekas
Copy link
Collaborator

mfazekas commented Nov 7, 2022

A major version change infers (potential) breaking changes. At least documenting those would be great.
I went through all pull requests in the posted git diff from 6.1.0 to 7.0.1. None of the descriptions mention any breakages (most PR descriptions are shockingly blank, though).

No breaking changes AFAIK, but in ruby almost any change is potentially breaking. Sorry I don't have much time to spend on net-ssh these days. It's safer to release new major releases, than to release a minor that might break something for someone, and the project has large install base.

Can you please point out an example pr, with no description, probably there was quite a few about infrastructure (GitHub actions, etc), but that should not be an issue.

We welcome a PR, with a proper changelog. We have changelogs until 6.3.0.beta so this is the diff that have to be converted into changelog:
v6.3.0.beta1...v7.0.1

@tisba
Copy link
Contributor

tisba commented Nov 9, 2022

Here we go: #884

I hope I captured everything that's relevant. There were a bunch of changes without a PR, so I tried to extract the important changes from commit messages and in part by reading the diff.

Let me know if I missed something of relevance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants