Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning of using is not for string compare #200

Closed
wants to merge 1 commit into from

Conversation

digizeph
Copy link

@digizeph digizeph commented Mar 4, 2020

Fix the following warning in python3.8

/usr/local/lib/python3.8/site-packages/netaddr-0.7.19-py3.8.egg/netaddr/strategy/__init__.py:189: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if word_sep is not '':

Fix the following warning in python3.8
```
/usr/local/lib/python3.8/site-packages/netaddr-0.7.19-py3.8.egg/netaddr/strategy/__init__.py:189: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if word_sep is not '':
```
@sbaerlocher
Copy link

Would be cool if the fix is implemented and a new version is created.

@max-wittig
Copy link

max-wittig commented Apr 18, 2020

Ansible seems to have upgraded their version now. Now it shows up everywhere.

@snordhausen
@drkjam

@sbaerlocher
Copy link

As I have seen, it would be fixed in the master branch already but a new release has been made so far!

@snordhausen @drkjam Can one of you make a new release with the fix?

Copy link

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... another fix for the same old problem.

@digizeph
Copy link
Author

digizeph commented Jun 5, 2020

Well... another fix for the same old problem.

(Well, your tone seems to suggest this was a duplicate PR. No other PR I can find fixes this when I created this PR.)

@sbaerlocher
Copy link

@digizeph It is fixed in the master branch but there is no new release where it is fixed.

https://github.com/netaddr/netaddr/blob/master/netaddr/strategy/__init__.py#L189

@digizeph
Copy link
Author

digizeph commented Jun 5, 2020

Ah, got it. Thanks, @sbaerlocher!

@jstasiak
Copy link
Contributor

Thanks for this, another patch addressing this has already been merged into the master branch (now released in 0.7.20), sorry about the confusion about the branches and the default branch, this should also be addressed now.

@jstasiak jstasiak closed this Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants