Handle RFC 6164 IPv6 addresses #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like RFC 3021, IPv6 defines point-to-point subnets that must be handled separately, i.e. don't reserve first IP address. This patch aims to implement this, while refactoring code in iter_host function to reduce code duplication. Tests for this feature also added to ensure there is no regression. Signed-off-by: Damien Claisse <d.claisse@criteo.com>
|
Thank you, merged into master as 2984c0a. |
|
@dclaisse We've decided to temporarily revert this before the 0.8.0 release and the documentation will be amended to let people in advance this behavior is going to change (there's a concern about backwards compatibility and people's codebases breaking). The patch will be reinstated in time for the 0.9.0 release so it won't be lost nor forgotten. |
|
This has been finally released in version 0.9.0 today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like RFC 3021, IPv6 defines point-to-point subnets that must
be handled separately, i.e. don't reserve first IP address.
This patch aims to implement this, while refactoring code in
iter_host function to reduce code duplication.
Tests for this feature also added to ensure there is no regression.
Signed-off-by: Damien Claisse d.claisse@criteo.com