Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc clients' keepalive interval #1231

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Oct 19, 2023

Describe your changes

Some reverse proxies might find 15s interval too short and respond with an enhance your-calm message:

2023/10/14 12:14:15 ERROR: [transport] Client received GoAway with error code ENHANCE_YOUR_CALM and debug data equal to ASCII "too_many_pings".

This change is setting the management and signal clients' keepalive interval to 30 seconds to minimize the number of reconnections

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Some reverse proxies might find 15s interval too short and respond with an enhance your-calm message

This change is setting the management and signal clients' keepalive interval to 30 seconds to minimize the number of reconnections
@mlsmaycon mlsmaycon merged commit a9f5fad into main Oct 19, 2023
12 of 14 checks passed
@mlsmaycon mlsmaycon deleted the update-grpc-clients-keepalive-interval branch October 19, 2023 08:18
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
Some reverse proxies might find 15s interval too short and respond with an enhance your-calm message

This change is setting the management and signal clients' keepalive interval to 30 seconds to minimize the number of reconnections
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
Some reverse proxies might find 15s interval too short and respond with an enhance your-calm message

This change is setting the management and signal clients' keepalive interval to 30 seconds to minimize the number of reconnections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants