Add gocritic linter #1324
Merged
Add gocritic linter #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surik
force-pushed
the
yury/add-gocritic
branch
from
cc4dc34
to
2d188fa
Compare
|
This PR more likely needs to be updated after #1327 |
`gocritic` provides diagnostics that check for bugs, performance and style issues We disable the following checks: - commentFormatting - captLocal - deprecatedComment
surik
force-pushed
the
yury/add-gocritic
branch
from
169f7ea
to
f9737e2
Compare
mlsmaycon
approved these changes
Nov 27, 2023
surik
added a commit
that referenced
this pull request
Dec 14, 2023
* Add gocritic linter `gocritic` provides diagnostics that check for bugs, performance, and style issues We disable the following checks: - commentFormatting - captLocal - deprecatedComment This PR contains many `//nolint:gocritic` to disable `appendAssign`.
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
* Add gocritic linter `gocritic` provides diagnostics that check for bugs, performance, and style issues We disable the following checks: - commentFormatting - captLocal - deprecatedComment This PR contains many `//nolint:gocritic` to disable `appendAssign`.
Foosec
pushed a commit
to Foosec/netbird
that referenced
this pull request
May 8, 2024
* Add gocritic linter `gocritic` provides diagnostics that check for bugs, performance, and style issues We disable the following checks: - commentFormatting - captLocal - deprecatedComment This PR contains many `//nolint:gocritic` to disable `appendAssign`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gocriticprovides diagnostics that check for bugs, performance, and style issuesWe disable the following checks:
This PR contains many
//nolint:gocriticto disableappendAssign.We may want to address them separately.
Describe your changes
Issue ticket number and link
Checklist