Implement lightweight method to check is peer has update channel #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of GetAllConnectedPeers that need to traverse the whole connections map in order to find one channel there.
mlsmaycon
approved these changes
Dec 5, 2023
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
…birdio#1351) Instead of GetAllConnectedPeers that need to traverse the whole connections map in order to find one channel there.
Foosec
pushed a commit
to Foosec/netbird
that referenced
this pull request
May 8, 2024
…birdio#1351) Instead of GetAllConnectedPeers that need to traverse the whole connections map in order to find one channel there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of GetAllConnectedPeers that needs to traverse the whole connections map to find one channel there.
This also removes update channel manager metrics with ms time unit as micro should be enough.
Describe your changes
Issue ticket number and link
Checklist