Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data dir creation permissions #1503

Merged
merged 1 commit into from Jan 29, 2024
Merged

Fix data dir creation permissions #1503

merged 1 commit into from Jan 29, 2024

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Jan 29, 2024 •
edited

Describe your changes

Uses proper permissions to create dirs. os.ModeDir creates a directory with no bits set

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@pappz pappz self-requested a review January 29, 2024 12:55
@lixmal lixmal merged commit 25b3641 into main Jan 29, 2024
18 checks passed
@lixmal lixmal deleted the fix-perms branch January 29, 2024 13:21
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
@lixmal
Fix data dir creation permissions (netbirdio#1503)
f6ffc31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pappz pappz pappz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lixmal @pappz