Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/resolv parser #1520

Merged
merged 3 commits into from Feb 2, 2024
Merged

Fix/resolv parser #1520

merged 3 commits into from Feb 2, 2024

Conversation

pappz
Copy link
Contributor

@pappz pappz commented Feb 2, 2024

Describe your changes

In case if the original resolv.conf file is empty then it can cause nil pointer

Issue ticket number and link

closes #1521

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

lixmal
lixmal previously approved these changes Feb 2, 2024
@mlsmaycon mlsmaycon merged commit a2f2a6e into main Feb 2, 2024
16 checks passed
@mlsmaycon mlsmaycon deleted the fix/resolv-parser branch February 2, 2024 16:54
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
fix an issue In case if the original resolv.conf file is empty, then it can cause a nil pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Empty backup resolv.conf causes panic on daemon start
3 participants