Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding 3 nameserver addresses #1588

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Feb 16, 2024

Describe your changes

Allows administrators to add a third nameserver configuration.

Dashboard PR: netbirdio/dashboard#337

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon mlsmaycon marked this pull request as ready for review February 19, 2024 12:22
@mlsmaycon mlsmaycon merged commit cb3408a into main Feb 19, 2024
16 checks passed
@mlsmaycon mlsmaycon deleted the allow-adding-3-nameservers branch February 19, 2024 13:29
@rgl
Copy link
Contributor

rgl commented Feb 22, 2024

Why limit the number at all?

Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants