Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to configure extra blacklist of iface in "up" command #1734

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

hoozecn
Copy link
Contributor

@hoozecn hoozecn commented Mar 21, 2024

Describe your changes

we can configure extra blacklist of iface in "up" command instead of editing config file

Issue ticket number and link

Checklist

  • [*] Is a feature enhancement

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
All committers have signed the CLA.

@braginini
Copy link
Contributor

Hey @hoozecn
Thank you for the contribution!

I think that this will only work in the foreground mode, which is mostly used only in Docker. A more traditional way is to use a dameon mode. The cmd communicates with a local dameon service through gRPC.

@hoozecn
Copy link
Contributor Author

hoozecn commented Mar 21, 2024

Yes. we use netbird client as Daemonset in Kubernetes so that the selected nodes will work as gateways of the cluster. the change in PR is enough for us and works well.

For your point, I'm happy to see to make it be configurable too in traditional way when we run netbird up in a "normal" node for instance a bare-metal node. I would like to check the codebase to see how to make it possible with gRPC.

But before that, do you think it worth a try?

@braginini
Copy link
Contributor

Yes. we use netbird client as Daemonset in Kubernetes so that the selected nodes will work as gateways of the cluster. the change in PR is enough for us and works well.

For your point, I'm happy to see to make it be configurable too in traditional way when we run netbird up in a "normal" node for instance a bare-metal node. I would like to check the codebase to see how to make it possible with gRPC.

But before that, do you think it worth a try?

I will sync with the team tomorrow morning and get back to you after. Thank you!

@hoozecn hoozecn force-pushed the feature/extra-iface-blacklist branch from becb046 to 857b270 Compare March 22, 2024 07:16
@hoozecn
Copy link
Contributor Author

hoozecn commented Mar 22, 2024

@braginini hey man, thanks for you sync. I have update the pr to support the daemon mode.

Just find another PR not merged #1586. Seems it's going to support to configure InterfaceBlacklist too.

The ExtraIFaceBlacklist option make help people avoid to provide the default blacklist in the command line. But use InterfaceBlacklist will be more explicit.

Which do you think is better?

@pappz pappz merged commit bd7a65d into netbirdio:main Mar 28, 2024
16 checks passed
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
…dio#1734)

Support to configure extra blacklist of iface in "up" command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants