Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get scope from endpoint url instead of hardcoding for Azure (Entra ID) #1770

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

rqi14
Copy link
Contributor

@rqi14 rqi14 commented Mar 29, 2024

Describe your changes

Get scope from endpoint url instead of hardcoding for Azure (Entra ID). This is to fix errors occured when the endpoint is not https://graph.microsoft.com.

Issue ticket number and link

#1663

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2024

CLA assistant check
All committers have signed the CLA.

@braginini braginini merged commit 9af532f into netbirdio:main Apr 2, 2024
16 checks passed
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants