Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate blob net ip fields to json serializer #1906

Merged
merged 8 commits into from
May 7, 2024

Conversation

bcmmbaga
Copy link
Contributor

Describe your changes

Migrates all net ip blob fields to serializer:json.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link
Contributor

@lixmal lixmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests to migration_test.go and maybe sqlite_store_test.go:TestMigrate please

lixmal
lixmal previously approved these changes Apr 30, 2024
mlsmaycon

This comment was marked as duplicate.

@mlsmaycon mlsmaycon requested a review from lixmal April 30, 2024 14:16
Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's validate using plain strings for net.IP

@bcmmbaga bcmmbaga merged commit ce0718f into main May 7, 2024
16 checks passed
@bcmmbaga bcmmbaga deleted the migrate-with-json-serializer branch May 7, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants