feat(cli): split login and up methods in the service CLI API #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braginini
reviewed
Feb 20, 2022
client/proto/daemon.proto
Outdated
| // Up starts engine work in the daemon. | ||
| rpc Up(UpRequest) returns (UpResponse) {} | ||
|
|
||
| // Down dengine work in the daemon. |
There was a problem hiding this comment.
minor typo/comment issue
braginini
requested changes
Feb 20, 2022
gigovich
force-pushed
the
feature-exctract-cli-from-client
branch
4 times, most recently
from
bf4401b
to
bb67850
Compare
gigovich
force-pushed
the
feature-exctract-cli-from-client
branch
5 times, most recently
from
57c23d4
to
3ffaf98
Compare
braginini
previously approved these changes
Mar 5, 2022
gigovich
force-pushed
the
feature-exctract-cli-from-client
branch
2 times, most recently
from
8ba3b5d
to
8e0f655
Compare
gigovich
force-pushed
the
feature-exctract-cli-from-client
branch
from
8e0f655
to
d62a828
Compare
braginini
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.