Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tor Browser stopped working with firejail after a major update #2110

Closed
ghost opened this issue Sep 7, 2018 · 21 comments
Closed

Tor Browser stopped working with firejail after a major update #2110

ghost opened this issue Sep 7, 2018 · 21 comments
Labels
information_old (Deprecated; use "doc-todo" or "needinfo" instead) Information was/is required

Comments

@ghost
Copy link

ghost commented Sep 7, 2018

I am using firejail-0.9.54 on Slackware64 Linux-14.2 and today Tor Browser updated itself from version 7.5.6 to version 8.0. After this Tor Browser doesn't work anymore when launched through firejail. Once the main window starts, it displays the message:

Gah. Your tab just crashed.

Same happens for any new opened tab. It works fine without firejail.

@smitsohu
Copy link
Collaborator

smitsohu commented Sep 7, 2018

Hi @somospocos, we believe this is already fixed for upcoming 0.9.56.

See defb5a4 and 736216c

General question: Should this go to etc-fixes?

@smitsohu smitsohu added the information_old (Deprecated; use "doc-todo" or "needinfo" instead) Information was/is required label Sep 7, 2018
@TNTBOMBOM
Copy link

This has been reported against TorProject and FF. because it effects both of them and tested by me:

FF 60:

https://bugzilla.mozilla.org/show_bug.cgi?id=1488078

TBB 8.0:

https://trac.torproject.org/projects/tor/ticket/27407#ticket

@SkewedZeppelin
Copy link
Collaborator

@TNTBOMBOM
This is not something that upstream Mozilla can/will fix, this is purely an issue with our profiles.

This issue that has been fixed since 0.9.54 for Firefox and derivatives
and is fixed for Tor Browser in master (future 0.9.56).

What version of Firejail are you running?

@TNTBOMBOM
Copy link

TNTBOMBOM commented Sep 8, 2018

@SkewedZeppelin 0.9.44.8 from debian stretch stable repo. if firejail have been fixing that why dont u push the changes to Debian Repo ??

@SkewedZeppelin
Copy link
Collaborator

@TNTBOMBOM 0.9.54 is available via stretch-backports

@TNTBOMBOM
Copy link

@SkewedZeppelin saw that , still bad if its a stable version then its better to be pushed for the stable repo.

@Vincent43
Copy link
Collaborator

Vincent43 commented Sep 8, 2018

That's not how Debian stable works. They take the last stable firejail version at the point of Debian release and stick with it forever. If you want to have firejail gradually updated to latest version then use backports, testing, unstable or different distro.

Security updates are exception, that's why they keep updating chromium and firefox esr.

@TNTBOMBOM
Copy link

@SkewedZeppelin @Vincent43 thats great it worked fine with FF , but sadly it break TBB. any idea how to overcome that?

@Vincent43
Copy link
Collaborator

Fixes for tor browser aren't part of 0.9.54, they will be in 0.9.56. For now you may copy profiles manually:
https://github.com/netblue30/firejail/blob/master/etc/start-tor-browser.profile
https://github.com/netblue30/firejail/blob/master/etc/torbrowser-launcher.profile

@HundyK
Copy link

HundyK commented Sep 12, 2018

Is the Tor fix part of 0.9.56~rc1?

I am running into the same problem with the tabs crashing on startup using 0.9.56~rc1.

@SkewedZeppelin
Copy link
Collaborator

@HundyK the fix for TBB is not in 0.9.56rc1, only master (future 0.9.56 release).

@chiraag-nataraj
Copy link
Collaborator

Which has now been released! Closing this for now, but please feel free to reopen if you still have this issue after upgrading.

@TNTBOMBOM
Copy link

TNTBOMBOM commented Oct 2, 2018

after adding profiles to /etc/firejail/torbrowser-launcher as copy/paste from this link:
https://github.com/netblue30/firejail/blob/master/etc/torbrowser-launcher.profile

result after that, by running firejail torbrowser-laucher will give:

user@debian:~$ firejail torbrowser-launcher 
Reading profile /etc/firejail/torbrowser-launcher.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-devel.inc
Reading profile /etc/firejail/disable-interpreters.inc
Reading profile /etc/firejail/disable-passwdmgr.inc
Reading profile /etc/firejail/disable-programs.inc
Error: cannot access profile file
user@debian:~$ 

@chiraag-nataraj please re-open this ticket

@Fred-Barclay
Copy link
Collaborator

Fred-Barclay commented Oct 2, 2018

@TNTBOMBOM What version of firejail are you using?
Can you also please run the following and paste the output back here?
firejail --debug torbrowser-launcher

Thanks!

EDIT: I expect you're using an older version of firejail that doesn't have /etc/firejail/disable-xdg.inc, but the profile you copied expects it. 😉 . If so, simply removing the line include /etc/firejail/disable-xdg.inc from your profile should fix this.

@TNTBOMBOM
Copy link

@Fred-Barclay

Big Thanks!!!

@Zypherspace
Copy link

Zypherspace commented Nov 23, 2018

Same problem here as TNTBOMBOM

firejail --debug torbrowser-launcher
Autoselecting /bin/bash as shell
Building quoted command line: 'torbrowser-launcher' 
Command name #torbrowser-launcher#
Found torbrowser-launcher profile in /usr/local/etc/firejail directory
Reading profile /usr/local/etc/firejail/torbrowser-launcher.profile
Error: cannot access profile file

Raw contents of https://github.com/netblue30/firejail/blob/master/etc/torbrowser-launcher.profile were cut/pasted, no file permissions changed. Tried removing the include /etc/firejail/disable-xdg.inc as suggested, same error. Running latest master from git.

@Vincent43
Copy link
Collaborator

What system you using?

@Zypherspace
Copy link

Zypherspace commented Nov 24, 2018

Fedora 29 Cinnamon. It is working on a fresh install of Fed 29 Plasma without any changes to profile.
I've reinstalled Tor-Browser. TB runs correctly outside Firejail.

I see some errors in terminal during TB launch:

$ firejail /usr/bin/torbrowser-launcher
Reading profile /usr/local/etc/firejail/torbrowser-launcher.profile
Reading profile /usr/local/etc/firejail/globals.local
Reading profile /usr/local/etc/firejail/disable-common.inc
Reading profile /usr/local/etc/firejail/disable-devel.inc
Reading profile /usr/local/etc/firejail/disable-interpreters.inc
Reading profile /usr/local/etc/firejail/disable-passwdmgr.inc
Reading profile /usr/local/etc/firejail/disable-programs.inc
Reading profile /usr/local/etc/firejail/whitelist-common.inc
Reading profile /usr/local/etc/firejail/whitelist-var-common.inc
Parent pid 28462, child pid 28463

Interface        MAC                IP               Mask             Status
lo                                  127.0.0.1        255.0.0.0        UP    
eth0-28462       9a:f1:78:a0:4c:91  192.168.50.247   255.255.255.0    UP    
Default gateway 192.168.50.1

Warning: skipping ca-certificates for private /etc
Warning fcopy: skipping /etc/crypto-policies/back-ends/openssh-server.config, cannot find inode
Private /etc installed in 33.96 ms
52 programs installed in 32.12 ms
Warning: cleaning all supplementary groups
Warning: cleaning all supplementary groups
Warning: cleaning all supplementary groups
Blacklist violations are logged to syslog
Child process initialized in 1106.97 ms

(torbrowser-launcher:76): Gtk-WARNING **: 02:01:11.697: Unable to locate theme engine in module_path: "murrine",

(torbrowser-launcher:76): Gtk-WARNING **: 02:01:11.697: Unable to locate theme engine in module_path: "murrine",

(torbrowser-launcher:76): Gtk-WARNING **: 02:01:11.697: Unable to locate theme engine in module_path: "murrine",

(torbrowser-launcher:76): Gtk-WARNING **: 02:01:11.697: Unable to locate theme engine in module_path: "murrine",

(torbrowser-launcher:76): Gtk-WARNING **: 02:01:11.697: Unable to locate theme engine in module_path: "murrine",

(torbrowser-launcher:76): Gtk-WARNING **: 02:01:11.697: Unable to locate theme engine in module_path: "murrine",

(torbrowser-launcher:76): Gtk-WARNING **: 02:01:11.697: Unable to locate theme engine in module_path: "murrine",
Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.2.9
https://github.com/micahflee/torbrowser-launcher
Refreshing local keyring...
Keyring refreshed successfully...
  No key updates for key: EF6E286DDA85EA2A4BA7DE684E2C6E8793298290
Launching './Browser/start-tor-browser --detach'...
`


```

@SkewedZeppelin
Copy link
Collaborator

@Zypherspace please see #2038 (comment)

@Zypherspace
Copy link

I tried the full scrub of firejail as detailed in #2038. I followed with a full recursive search and deleted any firejail remnants before reinstalling. Reinstalled with make rpms. Unfortunately I still see the Gah. Your tab just crashed. code on Tor-browser. Fedora has been updated several versions on the machine it's got a lot of ragtag symlinks, I'll reinstall a fresh release soon.

@Futureknows
Copy link

Commenting out seccomp fixed it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
information_old (Deprecated; use "doc-todo" or "needinfo" instead) Information was/is required
Projects
None yet
Development

No branches or pull requests

9 participants