Inventory - IP addresses missing from virtual machine interfaces

[biganthony]

ISSUE TYPE

• Bug Report

SOFTWARE VERSIONS

Ansible:

ansible 2.9.11

Netbox:

2.9.1

Collection:

1.0.1

SUMMARY

When interfaces is set to TRUE the IP address array is empty for all VMs

STEPS TO REPRODUCE

set interfaces: True in inventory yml

plugin: netbox.netbox.nb_inventory
api_endpoint: http://netbox
validate_certs: True
config_context: False
services: True
interfaces: True
fetch_all: False
plurals: False

group_by:
  - role

query_filters:
  - cluster_id: 1

compose:
  netbox_vm_id: id

EXPECTED RESULTS

interfaces": [
  {
   "description": "",
   "enabled": true,
   "id": 4,
   "ip_addresses": [
       "List of IP objects": "Example"
    ],
   "mac_address": null,
   "mode": null,
   "mtu": null,
   "name": "ens18",
   "tagged_vlans": [],
   "tags": [],
   "untagged_vlan": null,
   "url": "http://netbox/api/virtualization/interfaces/4/",
   "virtual_machine": {
    "id": 13,
    "name": "VM NAME",
    "url": "http://i/api/virtualization/virtual-machines/13/"
   }
  }
 ]

ACTUAL RESULTS

interfaces": [
  {
   "description": "",
   "enabled": true,
   "id": 4,
   "ip_addresses": [],
   "mac_address": null,
   "mode": null,
   "mtu": null,
   "name": "ens18",
   "tagged_vlans": [],
   "tags": [],
   "untagged_vlan": null,
   "url": "http://netbox/api/virtualization/interfaces/4/",
   "virtual_machine": {
    "id": 13,
    "name": "VM NAME",
    "url": "http://i/api/virtualization/virtual-machines/13/"
   }
  }
 ]

Might be related to this.
netbox-community/netbox#4721
#319

[haxorof]

Changes done in netbox-community/netbox#4721 causes this issue as I see it when looking into the code of nb_inventory.py

Within the selected lines (see links below) I replaced "interface" with "assigned_object_id":
https://github.com/netbox-community/ansible_modules/blob/v1.0.2/plugins/inventory/nb_inventory.py#L906
https://github.com/netbox-community/ansible_modules/blob/v1.0.2/plugins/inventory/nb_inventory.py#L918

Then I replaced ipaddress["interface"]["id"] with ipaddress["assigned_object_id"] in selected line:
https://github.com/netbox-community/ansible_modules/blob/v1.0.2/plugins/inventory/nb_inventory.py#L909

Those changes populate the ip_addresses as expected with v2.9. However to support NetBox v2.8 and v2.9+ requires a change here which I guess first look for assigned_object_id and if that is not found then try with interface as fallback to handle v2.8 and earlier.

Cheers!

[haxorof]

Did a PR #334 on this that I tested and where I try to address all NetBox versions

[haxorof]

This fix is not correct after I discovered that assigned_object_id is not unique so assigned_object_type also must be considered now. :/ Will have a go at it again

[haxorof]

Corrections done in PR #334

[biganthony]

Thank you for your quick work @haxorof

[haxorof]

Thank you for your quick work @haxorof

Happy to help! Especially when you suffer the non-backwards compatible changes in NetBox v2.9 yourself. 😄