Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new endpoints for vpn app #1162

Merged
merged 4 commits into from Feb 14, 2024
Merged

Add new endpoints for vpn app #1162

merged 4 commits into from Feb 14, 2024

Conversation

freddebacker
Copy link
Contributor

@freddebacker freddebacker commented Jan 31, 2024 •
edited

Related Issue

#1149

New Behavior

  • Add support in nb_lookup for the netbox 3.7 vpn.tunnel and vpn.tunnel_termination objects.
  • Depending on netbox version we are addressing, point the endpoints for l2vpn and l2vpn_termination to the correct app ipam or vpn

Fix l2vpn and l2vpn_termination support for netbox 3.7

Contrast to Current Behavior

Works against netbox 3.7 as well, which was broken because endpoint moved

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

...

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

@freddebacker freddebacker force-pushed the issues_1146_1149_patch branch 2 times, most recently from 30df3b6 to 3c4b34f Compare January 31, 2024 16:26
@freddebacker freddebacker marked this pull request as draft January 31, 2024 17:23
@freddebacker freddebacker marked this pull request as ready for review January 31, 2024 17:31
sc68cal
sc68cal reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@sc68cal sc68cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather see comparisons like (major, minor, patch) <= instead of declaring a new variable.

@rodvand rodvand merged commit 7111942 into netbox-community:devel Feb 14, 2024
8 checks passed
@rodvand rodvand mentioned this pull request Feb 14, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc68cal sc68cal sc68cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freddebacker @sc68cal @rodvand