test: fix assertions for mock calls #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alse Calling `MagicMock.called_once_with` returns a mock object and asserting that always succeeds. Replace this call with `MagicMock.assert_called_with` in `test_create_netbox_object_check_mode_false` since `endpoint_mock.create` is called twice: once in the test setup and once by `_create_netbox_object`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Calling `MagicMock.called_once`, `MagicMock.called_once_with`, or `MagicMock.not_called` returns a mock object and asserting that always succeeds. Replace those calls with their correct `MagicMock.assert_*` counterparts. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
sc68cal
approved these changes
Feb 21, 2024
sc68cal
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
MagicMock.called_once,MagicMock.called_once_with, orMagicMock.not_calledreturns a mock object and asserting that always succeeds.Replace those calls with their correct
MagicMock.assert_*counterparts.Discussion: Benefits and Drawbacks
Python 3.12 started to complain about it.
Proposed Release Note Entry
test: fix assertions for mock calls (for Python 3.12)
Double Check
develbranch.