Dont extract null values from custom fields (nb_inventory) #1184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
New Behavior
Only extract custom fields that are set. Netbox supports having non-required custom fields, and we don't want to set variables when the custom fields are not set in Netbox. This is particularly valuable if you are using flatten_custom_fields=True.
Contrast to Current Behavior
Custom fields that are not set in Netbox will be respected and not set in the Ansible module (e.g., they won't overwrite the variable if it's already set).
Discussion: Benefits and Drawbacks
When flatten_custom_fields=False, the custom fields which are unset will be excluded from the custom_fields dictionary. I don't think this will cause any issues.
Changes to the Documentation
...
Proposed Release Note Entry
Unset custom fields, in combination with
flatten_custom_fields=True
, will no longer overwrite host variables.Double Check
devel
branch.