#1141 Added virtual_disks to nb_inventory.py #1188
Conversation
|
This needs to add to the |
Added virtual_disks
added virtual_disks
Updated virtual_disks data in inventory file
corrected syntax error
syntax error corrected
No vdisks?
removed duplicate virtual disks
No vm disk in test enviroment test
I have not found a JSON file that have virtual disks in them? |
|
You need to add to existing JSON files or create new ones |
add virtual disks to test100-vm
added virtual disks to deploy
added to inventory
changed virtual machine to id
* Added virtual_disks to deploy * Added virtual_disks to inventory * Update data.json with virtual disks * Update test_nb_inventory.py * Update test-inventory.yml * fix integration tests --------- Co-authored-by: = <=>
| }, | ||
| "display": "Ethernet1/1", | ||
| "display": "Ethernet2/1", |
There was a problem hiding this comment.
Sorry, why were these changed? Your commit message does not indicate the reason
There was a problem hiding this comment.
The reason I ask is because it appears that you changed existing devices in these files instead of creating adding new devices in the inventory that tests your specific feature.
There was a problem hiding this comment.
The inventory files were created with the .hacking.
I have just adjusted these files according to the output that was generated with it. I added virtual disks to the netbox_deploy file and have not changed any existing devices.
I used a clean install of netbox with netbox-docker and done everything according to Contribution.
There was a problem hiding this comment.
Ok thank you for the explanation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Added virtual_disks support for inventory.
Related Issue
#1141
New Behavior
This adds virtual_disks to the inventory file. Multiple disks are also supported.
Contrast to Current Behavior
Due to the new feature of virtual disks this was not included in the inventory.
Discussion: Benefits and Drawbacks
Changes to the Documentation
virtual_disks is now added to nb_inventory and can be used with "virtual_disks: True"
Proposed Release Note Entry
Virtual_disks has been added to nb_inventory.py and can be used with "virtual_disks: True"
Double Check
Please put an x into the brackets (like
[x]) if you've completed that task.develbranch.