Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added label to power port module #1202

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

sapergus
Copy link
Contributor

@sapergus sapergus commented Apr 5, 2024

Related Issue

No related issues.

New Behavior

Added 'label' as a none required option to netbox_power_port module.
...

Contrast to Current Behavior

Possible to add a label to a power port in NetBox.
...

Discussion: Benefits and Drawbacks

We use NetBox in my organisation and I need to be able to create labels for powerports.
Since the option to add a label is optional it should not be a problem with backward compatibility.
...

Changes to the Documentation

Added a description of the label option in plugins/modules/netbox_power_port.py and generated a new version of
docs/plugins/netbox_power_port_module.rst.
...

Proposed Release Note Entry

...

Double Check

  • [ x] I have read the comments and followed the CONTRIBUTING.md.
  • [ x] I have explained my PR according to the information in the comments or in a linked issue.
  • [ x] My PR targets the devel branch.

Copy link
Contributor

@sc68cal sc68cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown docs are automatically generated I believe, so your change should only just be to the netbox_power_port.py file.

@rodvand rodvand merged commit 2481548 into netbox-community:devel Apr 12, 2024
8 checks passed
@sapergus sapergus deleted the feature/power_port_label branch April 30, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants