Add modules for cable, device_bay_template and virtual_chassis management #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sis settings to device module
|
@FragmentedPacket: Any comments so far? |
|
@FragmentedPacket: I have added modules for cable management and device_bay_template to this pull request since I don't want to rebase the code. Please have a look at the cable implementation. I think I found a quite good solution for now. |
toerb
changed the title
toerb
changed the title
|
I will spend some time this weekend and review everything! |
Suggestions for your PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in #137 this is the prototype for handling virtual chassis.
It is working but not very pretty in my opinion.
The main reason for this is the missing option to filter for
masterormaster_idin thevirtual-chassisendpoint.This solution uses the
qfilter to search for already existing virtual-chassis objects.