-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests with v3.0 #619
Conversation
NetBox v3.0 only has `display`. See breaking changes in the v3.0 release notes.
Need to remove `display` from devices since `display` used to be composed from `display_name`.
This is great @devon-mar! I would really like to get the CI working again on 3.0. I have updated the integration tests to run on python 3.8 in another PR, so that's sorted. Regarding #618, do you want to see if you can tackle it? |
This looks good so far. Will the netbox_site idempotency test be re-enabled in this patch series? I assume yes since this is still a draft but wanted to be sure |
Yes, I just disabled it to make sure the other tests are working but will re-enable it when |
@devon-mar I've just pushed a fix for netbox_site - could you pull from devel and enable the netbox_site test? 🤞 |
Looks good! I've also switched the v3.0 tests to use Python 3.8 like the others. |
Fixes #590
This PR updates the integration tests to work with v3.0
I had to disable the
netbox_site
idempotency test because of #618. Therefore, I'm creating this PR as a draft.Also, we should consider running integration tests with Python 3.8 or higher as Ansible 2.12 will require it.