Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests with v3.0 #619

Merged
merged 12 commits into from
Nov 2, 2021
Merged

Conversation

devon-mar
Copy link
Contributor

Fixes #590

This PR updates the integration tests to work with v3.0

I had to disable the netbox_site idempotency test because of #618. Therefore, I'm creating this PR as a draft.

Also, we should consider running integration tests with Python 3.8 or higher as Ansible 2.12 will require it.

@devon-mar devon-mar changed the title 3.0 ci Fix integration tests with v3.0 Oct 21, 2021
@rodvand
Copy link
Contributor

rodvand commented Oct 24, 2021

This is great @devon-mar! I would really like to get the CI working again on 3.0. I have updated the integration tests to run on python 3.8 in another PR, so that's sorted.

Regarding #618, do you want to see if you can tackle it?

@sc68cal
Copy link
Contributor

sc68cal commented Oct 28, 2021

This looks good so far. Will the netbox_site idempotency test be re-enabled in this patch series? I assume yes since this is still a draft but wanted to be sure

@devon-mar
Copy link
Contributor Author

This looks good so far. Will the netbox_site idempotency test be re-enabled in this patch series? I assume yes since this is still a draft but wanted to be sure

Yes, I just disabled it to make sure the other tests are working but will re-enable it when netbox_site is fixed.

@rodvand
Copy link
Contributor

rodvand commented Nov 1, 2021

@devon-mar I've just pushed a fix for netbox_site - could you pull from devel and enable the netbox_site test? 🤞

@devon-mar
Copy link
Contributor Author

@devon-mar I've just pushed a fix for netbox_site - could you pull from devel and enable the netbox_site test? 🤞

Looks good! I've also switched the v3.0 tests to use Python 3.8 like the others.

@devon-mar devon-mar marked this pull request as ready for review November 2, 2021 01:47
@rodvand rodvand merged commit d8f2b23 into netbox-community:devel Nov 2, 2021
@devon-mar devon-mar deleted the 3.0-ci branch November 2, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-Add support for NetBox 3.0.x in CI
3 participants