Create optional ServiceMonitor for Netbox #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Prometheus-Operator is a popular choice for collecting metrics, and many other projects (such as External-DNS [1]) have a pre-configured ServiceMonitor resource ready to be enabled; this does the same for Netbox. The template is very heavily inspired by the External-DNS one. 1: https://github.com/kubernetes-sigs/external-dns/blob/master/charts/external-dns/templates/servicemonitor.yaml
|
Tested with local rendering of templates then applying to a given cluster - this is doing the trick for me, so hopefully it'll be helpful for others, too. |
|
D'oh, didn't see #92 which does functionally the same thing. However, this doesn't introduce a breaking change, so might be preferred - feel free to approve/comment/close/other as you see fit, Chris. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prometheus-Operator is a popular choice for collecting metrics, and many other projects (such as External-DNS [1]) have a pre-configured ServiceMonitor resource ready to be enabled; this does the same for Netbox.
The template is very heavily inspired by the External-DNS one.
1: https://github.com/kubernetes-sigs/external-dns/blob/master/charts/external-dns/templates/servicemonitor.yaml