Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'serviceAccount.imagePullSecrets' option. #153

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Add 'serviceAccount.imagePullSecrets' option. #153

merged 2 commits into from
Nov 7, 2023

Conversation

rossigee
Copy link
Contributor

@rossigee rossigee commented Jun 3, 2023

Provides the option to set the imagePullSecrets on the ServiceAccount instead of the deployment.

@rossigee rossigee mentioned this pull request Jun 3, 2023
Closed
bootc
bootc requested changes Nov 4, 2023
View reviewed changes
Copy link
Member

@bootc bootc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the field to the table in the README.md.

@bootc
Copy link
Member

bootc commented Nov 4, 2023

Fixes #152

@bootc bootc linked an issue Nov 4, 2023 that may be closed by this pull request
Ability to add imagePullSecrets to ServiceAccount #152
Closed
@rossigee rossigee requested a review from bootc November 5, 2023 23:07
@bootc bootc merged commit 4bd3d4c into netbox-community:develop Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bootc bootc bootc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to add imagePullSecrets to ServiceAccount
2 participants
@rossigee @bootc