Leverage Bitnami common chart helpers
#184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoColomb
force-pushed
the
feat/bitnami-common
branch
2 times, most recently
from
55e1242
to
c8a5cdf
Compare
LeoColomb
force-pushed
the
feat/bitnami-common
branch
from
d8e8782
to
f25c010
Compare
LeoColomb
force-pushed
the
feat/bitnami-common
branch
from
62efcc9
to
c32c9db
Compare
LeoColomb
force-pushed
the
feat/bitnami-common
branch
from
c32c9db
to
567da6d
Compare
RangerRick
approved these changes
May 2, 2024
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request suggests using Bitnami
commonchart to significantly simplify maintenance while increasing the standardization.It could help generate proper labels, annotations, names, and attributes that match the latest Kubernetes operators expectations.
Note
This PR is only bringing a subset of the helpers Bitnami's common is provided.
It is to ensure we agree on the principle before further implmenetation.
Additionnal helpers includes:
Direct follow up of #162 (comment)