Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add settings for controlling http message sizes #194

Merged
merged 1 commit into from
May 3, 2024
Merged

feat: add settings for controlling http message sizes #194

merged 1 commit into from
May 3, 2024

Conversation

sjurtf
Copy link
Contributor

@sjurtf sjurtf commented May 3, 2024

Support setting DATA_UPLOAD_MAX_MEMORY_SIZE and FILE_UPLOAD_MAX_MEMORY_SIZE in configmap.

@sjurtf sjurtf marked this pull request as draft May 3, 2024 13:19
@sjurtf sjurtf closed this May 3, 2024
@sjurtf sjurtf reopened this May 3, 2024
@sjurtf sjurtf marked this pull request as ready for review May 3, 2024 13:39
RangerRick
RangerRick requested changes May 3, 2024
View reviewed changes
Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that one typo, this looks totally reasonable. Also if you bump the beta version, the test run should complete green.

charts/netbox/templates/configmap.yaml Outdated Show resolved Hide resolved
@RangerRick RangerRick merged commit 9f4b160 into netbox-community:develop May 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerRick RangerRick RangerRick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjurtf @RangerRick