Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Values.ingress.annotations check #207

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix Values.ingress.annotations check #207

merged 2 commits into from
May 13, 2024

Conversation

coolhome
Copy link
Contributor

Resolves #206

RangerRick
RangerRick approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dang, good catch!

LeoColomb
LeoColomb approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@LeoColomb LeoColomb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
(beta version needs to be bumped 😊)

@LeoColomb LeoColomb mentioned this pull request May 11, 2024
Closed
@RangerRick
Copy link
Contributor

well, the linter is being a jerk, but I'm going to merge this 'cause it's fine except for the version complaint :)

@RangerRick RangerRick merged commit 3165419 into netbox-community:develop May 13, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerRick RangerRick RangerRick approved these changes

@LeoColomb LeoColomb LeoColomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ingress.annotations no longer working
3 participants
@coolhome @RangerRick @LeoColomb