rename JOBRESULT_RETENTION to JOB_RETENTION

[marcquark]

Related Issue: none

New Behavior

When adding JOB_RETENTION as an environment variable to the netbox container, the value is now correctly passed on to the application. Furthermore, in order to not break existing setups that are upgraded without due care, if JOBRESULT_RETENTION is present it is passed on to the application as JOB_RETENTION.

Contrast to Current Behavior

The current behaviour breaks after upgrading to v3.5.0 or later since the release changed the variable's name from JOBRESULT_RETENTION to JOB_RETENTION.

Discussion: Benefits and Drawbacks

Should i also add a check and warning to docker-entrypoint.sh? On the one hand it would be convenient, on the other hand, doing so for every minor change like this may get out of hand.

Changes to the Wiki

not required

Proposed Release Note Entry

The JOBRESULT_RETENTION configuration parameter has been renamed to JOB_RETENTION to stay in line with NetBox.

Double Check

• I have read the comments and followed the PR template.
• I have explained my PR according to the information in the comments.
• My PR targets the develop branch.