Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1222: Use /login/ as health check URL #1223

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix #1222: Use /login/ as health check URL #1223

merged 1 commit into from
May 7, 2024

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented May 7, 2024

Related Issue: #1222

New Behavior

  • Use /login/ as health check URL

Contrast to Current Behavior

  • /api/ returns 403 when LOGIN_REQUIRED is true

Discussion: Benefits and Drawbacks

  • Health check works correctly again

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Fixed health check

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine May 7, 2024 05:18
cimnine
cimnine approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should request a proper healthcheck endpoint from upstream some time.

@tobiasge tobiasge merged commit 53ac2ff into netbox-community:develop May 7, 2024
9 checks passed
@tobiasge tobiasge deleted the 1222-fix-health-check branch May 7, 2024 06:37
@tobiasge tobiasge mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobiasge @cimnine