add hooks for running pre- and post-init scripts #1237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Look for
*.sh
scripts in/opt/init/pre/
and/opt/init/post/
. If they exist, run them (underbash -e
) in sort-order, at the beginning (before initializing venv) and end of the entrypoint, respectively.Contrast to Current Behavior
The current way to perform customizations at init is to either replace the entrypoint script in
CMD
, or to change it to call another script, both of which are a bit heavy-handed and rely too much on understanding the internals of the docker image.Discussion: Benefits and Drawbacks
Benefits:
Drawbacks:
Changes to the Wiki
It would be useful to expand the entry on extending the build to note the new hooks for adding scripts (including examples for mounting volumes manually, plus the
init-files
volume in thedocker-compose.yaml
).Proposed Release Note Entry
Provide hooks before startup of Netbox to perform additional initialization steps.
Double Check
develop
branch.