Add shared (z) container volume SELinux labels to the volumes created… #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by docker-compose.
cimnine
added
the
enhancement
|
Thank you for this PR. I will have a closer look at it as soon as possible. From the first glance this is a brilliant addition and indeed may fix the SELinux problems, a thing I didn't think was possible with "just docker-compose". |
|
I am currently confirming this does not break SELinux disabled scenarios. |
|
Alright I just checked with a permissive/disabled configuration and it also came online. |
|
Seems to work on Mac as well. |
cimnine
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… by docker-compose.
I've tested this on a fresh CentOS installation with SELinux enabled and enforcing and this allows all services to come online but would appreciate any additional testing.
These changes would also help in cases such as #110 and #97 .