Caching of requirements.txt #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After [a discussion][1] with rje6459 on the networktocode Slack in the #netbox-docker channel we've come up with a small improvement to those that regularly have to build netbox docker locally. It fetches the "requirements.txt" from the desired branch before downloading netbox itself. [1]: https://networktocode.slack.com/archives/CD23LP8BC/p1558537080023200
cimnine
force-pushed
the
improved_build_speed
branch
from
7c12b77
to
821fb5f
Compare
robellegate
suggested changes
May 23, 2019
There was a problem hiding this comment.
Copying my response from #netbox-docker channel on networktocode.slack.com:
Works well. I've looked into how the ADD instruction works and it seems that it will only invalidate it's cache if the source file changes, which is good for utilizing the Docker cache for build speed. One problem I'm still thinking of is the best way to invalidate the cache for the RUN instruction for wgetting netbox itself.
Could something like this work?
https://stackoverflow.com/a/39278224/7803239
Put it after the RUN instruction for pip install and the RUN instruction for wget?
I've submitted my own PR implementing this change #137
Edit: Didn't realize I could propose code changes w/o a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion with @rje6459 on the networktocode Slack
in the #netbox-docker channel we've come up with a small improvement
to those that regularly have to build netbox Docker images locally.
It basically fetches the "requirements.txt" from the desired branch before downloading netbox itself.