Optimise builds #274
Merged
Optimise builds #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks if the source materials (python image, Netbox commit, netbox-docker commit) have changed since the last build. This check is done by comparing the digest and commit ids from the previous image with the given tag to the current values taken from the Git and Docker repositories. The checks are only performed for builds by the automated builds on Github.
The old version of "build-branches.sh" skipped the pushing of images when one of them didn't change its sources. When looking at the Netbox branches I noticed that the "master" branch only changes when there is a new release. Because we build the new releases anyway in "build-latest.sh" that leaves "develop" and "develop-*" which change regularly. The new script "build-next.sh" is responsible for building "develop-*" as the next major release of Netbox. The build of "develop" is moved to the Github Action build matrix. This has the additional advantage of being faster because more builds are done in parallel.
Latest tag is now added to the new version when it is release by Netbox.
We are no longer building the images with Travis CI.
The variable for the latest tag didn't contain all the needed values.
The DOCKER_FROM is set to an empty value in the push tests. This expands the check to catch this test case
|
When I read through this, I start to think we should rewrite the build script in something else than bash, Python or so 🙈 |
|
I think for now Bash is OK, but if we want to add more functionality we should do that. |
Build now prints a message when no devlop-* branch is found instead of crashing
tobiasge
force-pushed
the
optimise-builds
branch
from
a021e07
to
7fb78b3
Compare
|
The builds in my repository with the new script have been stable for a while now. I think we can merge this. |
cimnine
reviewed
May 14, 2020
I did. But I found just found one more |
Include suggestion from cimnine Co-authored-by: Christian Mäder <cimnine@users.noreply.github.com>
cimnine
approved these changes
May 14, 2020
|
I believe we must update the repository settings shortly after this is merged to specify which of the new jobs are required to run and pass in order for a commit to get 'green'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Contrast to Current Behavior
Discussion: Benefits and Drawbacks
When following the "latest" or "v2.7" tags in Kubernetes or Openshift the containers were deployed everytime the GH Action ran. From now on the images are build only when something changed. So the automatic deployment is only triggered when really needed.
The image count was also reduced. Changes to the master branch in Netbox are only made when a new release is ready. So we don't need to build extra images for the latest tag. This tag now follows the newest version of Netbox.
Changes to the Wiki
Proposed Release Note Entry
Double Check
developbranch.