Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Fixed file permissions for media #276

Merged
merged 1 commit into from
May 6, 2020
Merged

Dockerfile: Fixed file permissions for media #276

merged 1 commit into from
May 6, 2020

Conversation

weisdd
Copy link

@weisdd weisdd commented Apr 18, 2020

Related Issue: #252

New Behavior

In case a container is executed with an arbitrary user id (e.g. "101" like in docker-compose.yml), Netbox has write permissions for all media folders (devicetype-images, image-attachments).

Contrast to Current Behavior

Netbox cannot create files inside devicetype-images and image-attachments if container's uid is not 0.

Discussion: Benefits and Drawbacks

Benefits:

  • Users don't have to apply any manual chmod tricks before they can upload images.

Drawbacks:

  • None

Changes to the Wiki

None

Proposed Release Note Entry

Dockerfile: Fixed file permissions for media folders

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge merged commit 5cb8e97 into netbox-community:develop May 6, 2020
@cimnine cimnine added this to the 0.24.0 milestone May 14, 2020
@tobiasge tobiasge mentioned this pull request May 15, 2020
3 tasks
@tobiasge tobiasge mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants