add option to mirror ldap groups into netbox #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimnine
reviewed
Oct 18, 2020
|
Thank you for this PR. Please see my comment. Also please rebase onto the latest |
cimnine
added
the
enhancement
|
Also: Sorry for the long wait. |
this commit allows ldap assigned groups to be mirrored into netbox users. The default is None as this is not the primary way to do this change.
madnutter56
force-pushed
the
mirror_ldap_groups
branch
from
b0dee49
to
9f4a9f5
Compare
cimnine
approved these changes
Oct 19, 2020
cimnine
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Users authenticating with LDAP will have their assigned groups mirrored into Netbox when the environment variable AUTH_LDAP_MIRROR_GROUPS is True
Contrast to Current Behavior
No change from current behaviour, as the default is None.
Discussion: Benefits and Drawbacks
Without the environment variable AUTH_LDAP_MIRROR_GROUPS set to True, groups are not mirrored, and parts of Netbox (such as the API) are unable to make use of LDAP group membership for permissions. This change introduces the ability to set this option when using Netbox through docker, and thus benefits members of the community who require this option.
This is not a breaking changes, and is therefore backwards compatible.
Proposed Release Note Entry
Double Check
developbranch.